Skip to content

[NewIR] Modify xx_new_ir_mode into xx_pir_mode #57201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2023
Merged

[NewIR] Modify xx_new_ir_mode into xx_pir_mode #57201

merged 4 commits into from
Sep 12, 2023

Conversation

DrRyanHuang
Copy link
Contributor

PR types

Others

PR changes

Others

Description

xx_new_ir_mode 替换为 xx_pir_mode

@paddle-bot
Copy link

paddle-bot bot commented Sep 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 11, 2023
@DrRyanHuang DrRyanHuang mentioned this pull request Sep 11, 2023
Closed
@DrRyanHuang
Copy link
Contributor Author

@Aurelius84 打扰了，麻烦杰哥看下

2023-09-11 23:00:15 ****************
2023-09-11 23:00:15 0. You must have one RD (XiaoguangHu01,chenwhql,zhiqiu,Xreki,luotao1,qili93,Aurelius84) approval for python/paddle/base/framework.py, which manages the underlying code for fluid.
2023-09-11 23:00:15 There are 1 approved errors.
2023-09-11 23:00:15 ****************

@Aurelius84 Aurelius84 changed the title xx_new_ir_mode => xx_pir_mode [NewIR] Modify xx_new_ir_mode into xx_pir_mode Sep 12, 2023
Aurelius84
Aurelius84 previously approved these changes Sep 12, 2023
View reviewed changes
wanghuancoder
wanghuancoder previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

sunzhongkai588
sunzhongkai588 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 5f30850 into PaddlePaddle:develop Sep 12, 2023
@DrRyanHuang DrRyanHuang deleted the new_ir_rename branch September 12, 2023 13:07
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@DrRyanHuang
[NewIR] Modify xx_new_ir_mode into xx_pir_mode (PaddlePaddle#57201)
52d4871 
* xx_new_ir_mode => xx_pir_mode

* manipulation new_ir 2 pir

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DrRyanHuang @zhhsplendid @jeff41404 @Aurelius84 @wanghuancoder @tianshuo78520a @sunzhongkai588