Skip to content

[NewIR] No.12 Migrate paddle.add into pir #57166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2023
Merged

[NewIR] No.12 Migrate paddle.add into pir #57166

merged 5 commits into from
Sep 13, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Sep 11, 2023 •
edited by 0x45f
Loading

PR types

Others

PR changes

Others

Description

TODO:

  • 在新IR下打开TestComplexElementwiseAddOp等几个Complex相关的单测

@paddle-bot
Copy link

paddle-bot bot commented Sep 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 11, 2023
@YuanRisheng
Copy link
Contributor

单测框架有适配更新，rerun了ci

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 11, 2023
@luotao1 luotao1 mentioned this pull request Sep 11, 2023
Closed
0x45f
0x45f reviewed Sep 11, 2023
View reviewed changes
test/legacy_test/test_elementwise_add_op.py Outdated
check_dygraph=self.check_dygraph(), check_prim=self.check_prim
check_dygraph=self.check_dygraph(),
check_prim=self.check_prim,
check_new_ir=True,
Copy link
Contributor

@0x45f 0x45f Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

将check_new_ir=True修改为check_new_ir=self.check_dygraph()吧。有的case在动态图下就会跳过检查，新IR下应该也不需要检查

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

test/legacy_test/test_elementwise_add_op.py Outdated
@@ -67,6 +69,7 @@ def test_check_grad_normal(self):
'Out',
check_dygraph=self.check_dygraph(),
check_prim=self.check_prim,
check_new_ir=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

test/legacy_test/test_elementwise_add_op.py Outdated
@@ -79,6 +82,7 @@ def test_check_grad_ingore_x(self):
no_grad_set=set("X"),
check_dygraph=self.check_dygraph(),
check_prim=self.check_prim,
check_new_ir=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

test/legacy_test/test_elementwise_add_op.py Outdated
@@ -91,6 +95,7 @@ def test_check_grad_ingore_y(self):
no_grad_set=set('Y'),
check_dygraph=self.check_dygraph(),
check_prim=self.check_prim,
check_new_ir=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

test/legacy_test/test_elementwise_add_op.py Outdated
@@ -147,6 +152,7 @@ def test_check_output(self):
atol=1e-3,
check_dygraph=self.check_dygraph(),
check_prim=self.check_prim,
check_new_ir=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里忘记修改了，麻烦再提个commit修改下~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@0x45f 0x45f merged commit c3cb34c into PaddlePaddle:develop Sep 13, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@enkilee
[NewIR] No.12 Migrate paddle.add into pir (PaddlePaddle#57166)
644bab4
@enkilee enkilee deleted the NewIR-no.12 branch December 19, 2023 05:32
@YuanRisheng YuanRisheng mentioned this pull request Mar 11, 2024
Closed
@risemeup1 risemeup1 mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@0x45f 0x45f 0x45f approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@phlrain phlrain phlrain approved these changes

Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enkilee @YuanRisheng @Aurelius84 @0x45f @phlrain @luotao1