function setitem support with stride #57023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jeff41404
reviewed
Sep 11, 2023
| x_tmp[:, 2] = 20 | ||
|
|
||
| np.testing.assert_allclose(x.numpy(), np_data) | ||
|
|
There was a problem hiding this comment.
shall we add test case of ellipsis index
There was a problem hiding this comment.
done, add a case to test ellipsis index.
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* function setitem support with stride * fix ut * remove redundant dygraph checks * add unittest for basic slice output view * add Ellipsis case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Pcard-66985
With the introduction of the stride mechanism in dygraph, and the relevant OPs output view has been enabled by default, indexing in Paddle needs to be adjusted accordingly.
In dygraph mode:
__getitem__: Basic-indexing will output view of Tensor.__setitem__: Advanced-indexing just assign value directly on the view of original Tensor, without an additional set_value. Moreover, we call set_value dygraph function instead of append_op, since the latter does not support the stride mechanism.