Skip to content

[PIR]Migrate fill_constant into pir #57020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 16, 2023
Merged

[PIR]Migrate fill_constant into pir #57020

merged 21 commits into from
Sep 16, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Sep 6, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

[PIR]Migrate fill_constant into pir

  • full op目前不支持可变attr，但是python端是支持可变attr，所以手写了full的python c api，在python c api这一层进行了分发，有可变attr时调用full_with_tensor op
  • 总共18个fill_constant相关单测，14个单测继承自OpTest已经全部打开，4个单测继承自unittest.TestCase未打开

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 6, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

0x45f added 10 commits September 6, 2023 07:13
@0x45f 0x45f mentioned this pull request Sep 12, 2023
Closed
@0x45f 0x45f changed the title [NewIR]Call _C_ops.full in new ir [PIR]Migrate fill_constant into pir Sep 14, 2023
Aurelius84
Aurelius84 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 99831e0 into PaddlePaddle:develop Sep 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@0x45f
[PIR]Migrate fill_constant into pir (PaddlePaddle#57020)
1812999 
* Call _C_ops.full in new ir

* Fix shape attr

* Fix yaml and infermeta

* Refine code

* Use full with tensor op

* Refine code

* Remove breakpoint

* Fix full

* Call stack when use full_with_tensor

* Refine code

* Refine code

* Refine code
@YuanRisheng YuanRisheng mentioned this pull request Mar 11, 2024
Closed
@risemeup1 risemeup1 mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@phlrain phlrain phlrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x45f @Aurelius84 @phlrain