Skip to content

[NewIR]Part-2.1 Refactor NewIRCompiler to support Group Ops #56762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 1, 2023
Merged

[NewIR]Part-2.1 Refactor NewIRCompiler to support Group Ops #56762

merged 8 commits into from
Sep 1, 2023

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Aug 29, 2023 •
edited
Loading

PR types

Function optimization

PR changes

Others

Description

Pcard-67164

what's New?

see: #56880
为支持Group Ops 编译的前置PR：

  • 统一复用了ParallelCompiler中的OpLower 组件逻辑
  • 升级OpLower为Pimpl隔离实现，并抽象OpLowererImplBase，派生新旧IR子类，通过CreateOpLower 模版特化管理new ir 分支，方便后续旧逻辑退场
image

what's Next?

  • 适配 NewIRCompiler.Build(GroupPtr)，添加单测
  • 添加 cinn::GroupOps，取代 newir::GroupPtr 数据结构
    • GroupOps 的 OpPatterKind 正确标记
    • GroupOps 的 Input/Output Names 正确解析，移除中间变量的标记

@paddle-bot
Copy link

paddle-bot bot commented Aug 29, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aurelius84 Aurelius84 requested a review from BiynXu August 29, 2023 13:18
@Aurelius84 Aurelius84 requested a review from YuanRisheng August 31, 2023 07:18
YuanRisheng
YuanRisheng reviewed Aug 31, 2023
View reviewed changes
BiynXu
BiynXu approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@BiynXu BiynXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winter-wang
winter-wang approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winter-wang
winter-wang reviewed Sep 1, 2023
View reviewed changes
XiaoguangHu01
XiaoguangHu01 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 7adb470 into PaddlePaddle:develop Sep 1, 2023
This was referenced Sep 1, 2023
Closed
Closed
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@Aurelius84 @BeingGod
[NewIR]Part-2.1 Refactor NewIRCompiler to support Group Ops (PaddlePa…
7d1d7da 
…ddle#56762)

* [NewIR]Part-2.1 Refactor NewIRCompiler to support Group Ops

* fix gflags link error

* fix include ir_printer.h

* fix unittest

* fix conflict

* fix flags

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winter-wang winter-wang winter-wang approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@phlrain phlrain phlrain approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@BiynXu BiynXu BiynXu approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@DrRyanHuang DrRyanHuang Awaiting requested review from DrRyanHuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Aurelius84 @YuanRisheng @raindrops2sea @phlrain @XiaoguangHu01 @BiynXu @winter-wang @zhangbo9674