Skip to content

Conversation

Candy2Tang
Copy link
Contributor

@Candy2Tang Candy2Tang commented Aug 13, 2023

PR types

Others

PR changes

Docs

Description

对应tracking issue: #55629
预览链接:

  • en: 生成中...
  • zh: 生成中...

@paddle-bot
Copy link

paddle-bot bot commented Aug 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 13, 2023
@paddle-bot
Copy link

paddle-bot bot commented Aug 13, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@Candy2Tang Candy2Tang changed the title [xdoctest][task 114] test=docs_preview [xdoctest][task 114] Reformat example code with google style in python/paddle/nn/functional/vision.py Aug 13, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Aug 14, 2023
Comment on lines 481 to 487
Tensor(shape=[1, 6, 1, 1], dtype=float32, place=Place(cpu), stop_gradient=True,
[[[[0. ]],
[[0.10000000]],
[[0.20000000]],
[[0.30000001]],
[[0.40000001]],
[[0.50000000]]]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体缩进层级 -1 吧,TensorT>>> 的第一个 > 对齐

Copy link
Contributor Author

@Candy2Tang Candy2Tang Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个有什么规范么?在其他PR里(如 Net 网络打印)是与 print 单词对齐的。对于Tensor是与 >>> 第一个 > 对齐,似乎不太一致呢。
我先按照这里的意见缩进-1吧,好像我文件内自己就没有对齐😓

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个有什么规范么?

输出统一与 > 对齐吧,不要与语句开始对齐

[[0.50000000]]]])
>>> y = F.channel_shuffle(x, 3)
>>> print(y)
Tensor(shape=[1, 6, 1, 1], dtype=float32, place=Place(cpu), stop_gradient=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好哒,已修复~~

Comment on lines 258 to 261
Tensor(shape=[1, 1, 3, 4], dtype=float64, place=Place(cpu), stop_gradient=True,
[[[[ 0.34000000, 0.01600000, 0.08600000, -0.44800000],
[ 0.55000000, -0.07600000, 0.35000000, 0.59000000],
[ 0.59600000, 0.38000000, 0.52000000, 0.24000000]]]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好哒,已修复

>>> x = paddle.randn([2, 1, 12, 12])
>>> out = F.pixel_unshuffle(x, 3)
>>> print(out.shape)
>>> # [2, 9, 4, 4]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里作为输出进行比较吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好哒,已经去除了 #

@Candy2Tang Candy2Tang requested a review from SigureMo August 18, 2023 08:56
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 merged commit cbade6a into PaddlePaddle:develop Aug 21, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
…n/paddle/nn/functional/vision.py (PaddlePaddle#56230)

* [xdoctest][task 114] test=docs_preview

* test=document_fix

* test=document_fix

* adjust indent

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants