Skip to content

[clang-tidy] No.48 enable clang-analyzer-unix.Malloc #55658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2023
Merged

[clang-tidy] No.48 enable clang-analyzer-unix.Malloc #55658

merged 3 commits into from
Nov 6, 2023

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Jul 24, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

启用 No.48 clang-analyzer-unix.Malloc 规则。

修复了 /paddle/paddle/fluid/operators/detection/mask_util.cc 中的两个警告。

@GreatV
Copy link
Contributor

GreatV commented Jul 24, 2023

我这有4处

/paddle/paddle/phi/kernels/funcs/gpc.cc:1638:26: error: Potential leak of memory pointed to by 'sbtree' [clang-analyzer-unix.Malloc,-warnings-as-errors]
    result->num_strips = 0;
/paddle/paddle/fluid/platform/init.cc:426:5: error: Potential memory leak [clang-analyzer-unix.Malloc,-warnings-as-errors]
    google::InstallFailureSignalHandler();
/paddle/paddle/fluid/operators/detection/mask_util.cc:227:1: error: Potential leak of memory pointed to by 'msk' [clang-analyzer-unix.Malloc,-warnings-as-errors]
}
/paddle/paddle/fluid/operators/detection/mask_util.cc:227:1: error: Potential leak of memory pointed to by 'msk_i' [clang-analyzer-unix.Malloc,-warnings-as-errors]
}

@GreatV GreatV mentioned this pull request Jul 24, 2023
Closed
@paddle-bot paddle-bot bot added the contributor External developers label Jul 24, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 25, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 26, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 26, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 3, 2023

Sorry to inform you that 38f3f45's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
@RedContritio
Copy link
Contributor Author

@GreatV 待 review

@GreatV GreatV requested a review from zhangbo9674 November 6, 2023 04:49
@luotao1 luotao1 added HappyOpenSource 快乐开源活动issue与PR and removed HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 labels Nov 6, 2023
@luotao1 luotao1 merged commit a9c7ff2 into PaddlePaddle:develop Nov 6, 2023
@RedContritio RedContritio deleted the clang_tidy_Malloc branch November 6, 2023 16:03
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
@RedContritio @zeroRains
[clang-tidy] No.48 enable clang-analyzer-unix.Malloc (PaddlePaddle#…
b4c9491 
…55658)

* enable clang-analyzer-unix.Malloc rule in clang-tidy

* fix 2 Malloc clang-tidy

* add comment
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@RedContritio
[clang-tidy] No.48 enable clang-analyzer-unix.Malloc (PaddlePaddle#…
fc39738 
…55658)

* enable clang-analyzer-unix.Malloc rule in clang-tidy

* fix 2 Malloc clang-tidy

* add comment
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@RedContritio @SecretXV
[clang-tidy] No.48 enable clang-analyzer-unix.Malloc (PaddlePaddle#…
4947be0 
…55658)

* enable clang-analyzer-unix.Malloc rule in clang-tidy

* fix 2 Malloc clang-tidy

* add comment
@RedContritio RedContritio mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees

@luotao1 luotao1

@GreatV GreatV

@zhangbo9674 zhangbo9674

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedContritio @GreatV @zhangbo9674 @luotao1