Skip to content

[test]mv fluid [controlflow,detection,dlnne,tensorrt] tests to tests #53470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 11, 2023
Merged

[test]mv fluid [controlflow,detection,dlnne,tensorrt] tests to tests #53470

merged 13 commits into from
May 11, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Apr 28, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

mv fluid controlflow,detection,dlnne,tensorrt tests to test/cpp/fluid

@paddle-bot
Copy link

paddle-bot bot commented Apr 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 28, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 28, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@gouzil gouzil mentioned this pull request Apr 29, 2023
Merged
gouzil added 2 commits May 4, 2023 16:08
@gouzil
Merge branch 'develop' of github.com:gouzil/Paddle into mv-fluid-dire…
043c4bd 
…ctory

# Conflicts:
#	test/cpp/fluid/CMakeLists.txt
@gouzil
Merge branch 'develop' of github.com:gouzil/Paddle into mv-fluid-dire…
e315dce 
…ctory

# Conflicts:
#	test/cpp/fluid/CMakeLists.txt
@luotao1
Copy link
Contributor

luotao1 commented May 5, 2023

需要解决冲突

@gouzil
Merge branch 'develop' of github.com:gouzil/Paddle into mv-fluid-dire…
4b2c47f 
…ctory

# Conflicts:
#	test/cpp/fluid/CMakeLists.txt
@gouzil
Copy link
Member Author

gouzil commented May 5, 2023

需要解决冲突

Done

@gouzil gouzil mentioned this pull request May 7, 2023
Closed
@gouzil
Copy link
Member Author

gouzil commented May 8, 2023

研发大哥帮忙看一下, windows-inference ci的 1/4 Test #1425: test_tensorrt_engine_op .....................Exit code 0xc000007b是啥问题

@luotao1 luotao1 mentioned this pull request May 8, 2023
Closed
@tianshuo78520a
Copy link
Collaborator

稍等下，我找负责人看下

tianshuo78520a
tianshuo78520a reviewed May 8, 2023
View reviewed changes
paddle/fluid/operators/tensorrt/CMakeLists.txt Outdated
@@ -1,9 +1,5 @@
op_library(tensorrt_engine_op DEPS tensorrt_engine tensorrt_converter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像也要迁移，否则编译出来的单测会有问题

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我又看了下，感觉并不是这个问题

@tianshuo78520a
Copy link
Collaborator

单测报错好像是windows操作系统相关问题，不太好排查，可以先跳过test_tensorrt_engine_op单测，先迁移其他目录，非常感谢！

@gouzil
Copy link
Member Author

gouzil commented May 8, 2023

单测报错好像是windows操作系统相关问题，不太好排查，可以先跳过test_tensorrt_engine_op单测，先迁移其他目录，非常感谢！

需不需要先预留test/cpp/fluid/tensorrt文件夹和CMakeLists.txt文件, 还是说我直接还原了

@gouzil gouzil requested a review from tianshuo78520a May 10, 2023 03:52
tianshuo78520a
tianshuo78520a previously approved these changes May 11, 2023
View reviewed changes
zhangbo9674
zhangbo9674 previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zyfncg
zyfncg previously approved these changes May 11, 2023
View reviewed changes
test/cpp/fluid/CMakeLists.txt
Comment on lines +26 to +28
# if(WITH_GPU AND TENSORRT_FOUND)
# add_subdirectory(tensorrt)
# endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的注释代码如果暂时要保留的话可以加些Note说明

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gouzil gouzil dismissed stale reviews from zyfncg, zhangbo9674, and tianshuo78520a via 600c787 May 11, 2023 02:45
@luotao1
Copy link
Contributor

luotao1 commented May 11, 2023

@gouzil 可以用 test=document_fix 来加速 CI

@gouzil
Copy link
Member Author

gouzil commented May 11, 2023

@gouzil 可以用 test=document_fix 来加速 CI

Done

@luotao1 luotao1 merged commit 8075752 into PaddlePaddle:develop May 11, 2023
@gouzil gouzil deleted the mv-fluid-directory branch May 15, 2023 14:41
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 14, 2023
@gouzil gouzil mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a left review comments

@zhangbo9674 zhangbo9674 zhangbo9674 left review comments

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

@zhangbo9674 zhangbo9674

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gouzil @luotao1 @tianshuo78520a @zyfncg @zhangbo9674 @zhiqiu