Skip to content

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jan 28, 2023

PR types

Others

PR changes

Others

Describe

This PR removes python/paddle/fluid/incubate/fleet/parameter_server/pslib/ps_pb2.py and add the corresponding paddle/fluid/distributed/ps.proto file.

Note that since I do not know where the exact ps.proto is (the exact commit id), I re-generated the ps.proto from the old ps_pb2.py file. The re-generation process is referred from https://stackoverflow.com/questions/70479912/reverse-engineering-proto-files-from-pb2-py-generated-with-protoc .

@paddle-bot
Copy link

paddle-bot bot commented Jan 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zmxdream zmxdream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit ba67361 into PaddlePaddle:develop Jan 29, 2023
@sneaxiy sneaxiy deleted the add_missing_proto_file branch January 29, 2023 03:17
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
* add missing proto file

* fix windows ci

* fix ci compile error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants