[Phi decouple] remove dependece to "paddle/fluid/platform/device/xpu/xxx.h" in phi #48420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@YuanRisheng ，帮忙 review 一下。 |
YuanRisheng
approved these changes
Nov 28, 2022
|
这个PR暂时不要合入，待我找xpu负责人review后再合入 |
明白了 |
|
@luotao1 ，这个 PR 相关的两个头文件已经清理完了，帮忙在 tracking issue 里备注一下。 |
@huangjiyi 已更新 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
移除
phi对paddle/fluid/platform/device/xpu目录下两个头文件xpu_header.h和xpu_op_list.h的依赖。#include "paddle/fluid/platform/device/xpu/xpu_header.h"替换为#include "paddle/phi/backends/xpu/xpu_header.h".xpu_op_list.h,xpu_op_list.cc中phi用到的函数移动至paddle/phi/backends/xpu目录下，并修改相应的 cmake 文件。