Skip to content

[CodeStyle][isort] introduce isort (part2) #48390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 25, 2022

PR types

Others

PR changes

Others

Describe

引入 isort 第二部分,格式化剩余单测代码一部分(test_[a-l]**

isort python/paddle/fluid/tests/unittests/test_[a-l]**

Note

为避免冲突,本 PR 不修改配置,将在主要 PR merge 后统一修改

Related links

@paddle-bot
Copy link

paddle-bot bot commented Nov 25, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 25, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][isort] introduce isort (part2) [CodeStyle][isort] introduce isort (part2) Nov 25, 2022
@luotao1 luotao1 self-assigned this Nov 28, 2022
luotao1
luotao1 previously approved these changes Nov 29, 2022
XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 29, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Nov 29, 2022

@SigureMo 请解决下冲突

@SigureMo SigureMo dismissed stale reviews from XiaoguangHu01 and luotao1 via e65c3c2 November 29, 2022 03:52
@SigureMo
Copy link
Member Author

@luotao1 冲突已解决,CI 也过啦~

lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
* isort all files

* revert conflicting files

* revert conflicting files

* revert conflicting files

* revert conflicting files

* revert conflicting files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants