Skip to content

Conversation

xiaoxiaohehe001
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

  • Add where trt converter.
  • 由于 where op 输入 condition 是 bool,支持trt engine bool 型作为输入。

@paddle-bot
Copy link

paddle-bot bot commented Nov 9, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Wangzheee
Wangzheee previously approved these changes Nov 10, 2022
Copy link
Contributor

@Wangzheee Wangzheee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

std::string input_x_name = op_desc.Input("X").front();
std::string condition_name = op_desc.Input("Condition").front();
std::string input_y_name = op_desc.Input("Y").front();
std::string output_name = op_desc.Output("Out")[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前面用的front,这里用[0] ....

jiweibo
jiweibo previously approved these changes Nov 10, 2022
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM of bool

zhoutianzi666
zhoutianzi666 previously approved these changes Nov 10, 2022
Copy link
Contributor

@zhoutianzi666 zhoutianzi666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangjun
zhangjun previously approved these changes Nov 10, 2022
Copy link
Contributor

@zhangjun zhangjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +66 to +67
case FluidDT::VarType_Type_BOOL:
return TRT_DT::kBOOL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast是不是也和这个有关

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants