Fix bugs in the General Plugin Mechanism #47072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
qingqing01
previously approved these changes
Oct 17, 2022
zhangjun
reviewed
Oct 17, 2022
| @@ -287,15 +287,21 @@ bool GenericPlugin::supportsFormatCombination( | |||
| const nvinfer1::PluginTensorDesc* in_out, | |||
| int nb_inputs, | |||
| int nb_outputs) TRT_NOEXCEPT { | |||
| bool is_linear_input = in_out[pos].format == nvinfer1::TensorFormat::kLINEAR; | |||
There was a problem hiding this comment.
是不是可以这里增加
if(!is_linear_input) return false;
qingqing01
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
修复通用 plugin 机制中的bug