Skip to content

[CodeStyle][E713] Convert 'not ... in ' into 'not in' #46734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2022
Merged

[CodeStyle][E713] Convert 'not ... in ' into 'not in' #46734

merged 4 commits into from
Oct 11, 2022

Conversation

caolonghao
Copy link
Contributor

@caolonghao caolonghao commented Oct 3, 2022 •
edited by SigureMo
Loading

PR types

Others

PR changes

Others

Describe

Convert not ... in into not in

Related Links

Flake8 tracking issue: #46039
配置文件更新: #46855
Fix: cattidea/paddle-flake8-project#63

@paddle-bot
Copy link

paddle-bot bot commented Oct 3, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 3, 2022
@caolonghao caolonghao mentioned this pull request Oct 3, 2022
Closed
@SigureMo SigureMo self-requested a review October 3, 2022 16:17
@SigureMo SigureMo mentioned this pull request Oct 3, 2022
Closed
SigureMo
SigureMo approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM～～～

PR-CI-Coverage 应该 re-run 下就可以过了～

@caolonghao
Copy link
Contributor Author

@SigureMo PR-CI-Coverage重新构建后仍然无法通过，具体的报错如图：
image

@SigureMo
Copy link
Member

SigureMo commented Oct 4, 2022 •
edited
Loading

@SigureMo PR-CI-Coverage重新构建后仍然无法通过，具体的报错如图：

之前是卡在编译失败上了，应该只是 CI 不稳定导致的，所以需要 re-run 下，保证后续单测什么的能跑通～

现在编译成功单测也通过只是卡在测试覆盖率不够，覆盖率不够因为与本 PR 修改无关，工作日问下能否豁免即可～

@caolonghao
Copy link
Contributor Author

感谢回复，了解了。

@luotao1 luotao1 self-assigned this Oct 10, 2022
@caolonghao caolonghao mentioned this pull request Oct 10, 2022
Merged
@luotao1 luotao1 merged commit 7ad6d9e into PaddlePaddle:develop Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E713] test for membership should be ‘not in’
3 participants
@caolonghao @SigureMo @luotao1