Skip to content

Conversation

caolonghao
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

Remove F541 code in flake8 config

Related Links

Flake8 tracking issue: #46039
Modify f-strings without curly braces: #46700

@paddle-bot
Copy link

paddle-bot bot commented Oct 2, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

SigureMo
SigureMo previously approved these changes Oct 2, 2022
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

这种仅仅修改配置文件的可以在最后一条 commit message 里添加 test=document_fix 来加速 CI(绝大多数 CI 都会直接跳过)

https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/git_guides/paddle_ci_manual_cn.html#yigaishu

这在工作日非常有用,不过这个已经跑完了,就不用改了(Windows 那俩这两天不知道咋了一直排队,先不用管)~

@caolonghao
Copy link
Contributor Author

LGTM~

这种仅仅修改配置文件的可以在最后一条 commit message 里添加 test=document_fix 来加速 CI(绝大多数 CI 都会直接跳过)

https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/git_guides/paddle_ci_manual_cn.html#yigaishu

这在工作日非常有用,不过这个已经跑完了,就不用改了(Windows 那俩这两天不知道咋了一直排队,先不用管)~

收到,后面的会调整~

@luotao1 luotao1 self-assigned this Oct 10, 2022
@luotao1
Copy link
Contributor

luotao1 commented Oct 10, 2022

@caolonghao 请解决下冲突

@paddle-bot
Copy link

paddle-bot bot commented Oct 10, 2022

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@caolonghao caolonghao deleted the F541/config branch October 10, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants