[CodeStyle][F522] Remove unused arguments #46743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Oct 4, 2022
| @@ -615,7 +615,7 @@ def is_dir(self, fs_path): | |||
| return self._is_dir(fs_path) | |||
|
|
|||
| def _is_dir(self, fs_path): | |||
| cmd = "test -d {}".format(fs_path, redirect_stderr=True) | |||
| cmd = "test -d {}".format(fs_path) | |||
There was a problem hiding this comment.
这里我怀疑是想将 redirect_stderr=True 插入到下一行的 _run_cmd 里，结果误插入到了这个 format 这里 😂，具体怎么改工作日讨论下吧，这里就先别动啦～
当然目前这么改是没有任何问题的，不会对现有代码造成任何影响～
可以更新下配置文件了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Fix F522: remove unused arguments
Related Links
Flake8 tracking issue: #46039
配置文件更新: #47287
Fix: cattidea/paddle-flake8-project#54