Skip to content

[CodeStyle][F402] Change the loop variable name which is the same with an imported module #46698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2022
Merged

[CodeStyle][F402] Change the loop variable name which is the same with an imported module #46698

merged 5 commits into from
Oct 10, 2022

Conversation

caolonghao
Copy link
Contributor

@caolonghao caolonghao commented Oct 1, 2022 •
edited by SigureMo
Loading

PR types

Others

PR changes

Others

Describe

修复 python\paddle\fluid\tests\unittests\test_auto_parallel_partitioner.py 中 F402 循环变量使用 import 过的模块名字

Related Links

@paddle-bot
Copy link

paddle-bot bot commented Oct 1, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 1, 2022
@caolonghao caolonghao mentioned this pull request Oct 1, 2022
Merged
@SigureMo SigureMo self-requested a review October 1, 2022 17:19
@caolonghao caolonghao changed the title [WIP][CodeStyle][F402] Change the loop variable name which is the same with an imported module [CodeStyle][F402] Change the loop variable name which is the same with an imported module Oct 1, 2022
@SigureMo SigureMo mentioned this pull request Oct 1, 2022
Closed
@caolonghao
Change variable name
fa04eb1 
Change variable name 'temp_tensor' to 'var' to avoid confusion, as var
also appears in the same file.
@SigureMo SigureMo self-requested a review October 2, 2022 08:53
SigureMo
SigureMo approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@SigureMo
Copy link
Member

SigureMo commented Oct 9, 2022

PR-CI-Windows 和 PR-CI-Windows-Inference 已经好啦，麻烦 re-run 下之前 PR 的这两个流水线，如果有其他流水线挂的也要 re-run 下（除了 PR-CI-APPROVAL 和 PR-CI-Static-Check）

re-run 后估计大多数 PR 就在过两天就可以 merge 啦～～～

@caolonghao
Copy link
Contributor Author

了解~

@luotao1 luotao1 merged commit 3a442a6 into PaddlePaddle:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[F402] import module from line N shadowed by loop variable
3 participants
@caolonghao @SigureMo @luotao1