[CodeStyle] remove some yapf: disable
#46410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
commented
Sep 22, 2022
| @@ -653,10 +652,19 @@ def to_safe_name(s): | |||
| ('test_2d_input2', rand_x(2, np.float64, shape=[8, 150]), 50, 15, -1), | |||
| ('test_3d_input1', rand_x(3, np.float64, shape=[150, 4, 2]), 50, 15, 0), | |||
| ('test_3d_input2', rand_x(3, np.float64, shape=[4, 2, 150]), 50, 15, -1), | |||
| ]) | |||
| ]) # yapf: disable | |||
There was a problem hiding this comment.
这个文件使用第二种方式，仅在 test case 参数部分取消格式化，避免格式化后的参数看起来非常凌乱的问题
yapf: disableyapf: disable
This was referenced Sep 23, 2022
umiswing
pushed a commit
to umiswing/Paddle
that referenced
this pull request
Sep 28, 2022
* remove `yapf: disable` from math.py * disable test case only * remove useless disable * remove useless disable * revert no_grad_set_white_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
对错误的
yapf: disable进行调整yapf 会停止单行
# yapf: disable到单行# yapf: enable之间的格式化，一些文件使用了这种方式但却没有重新 enable，因此很多没必要 disable 的都被 disable 了此外，yapf 支持行内使用
# yapf: disable来禁用某一个字面量的格式化，可以通过这种方式避免大面积被 disable 掉参考：https://github.com/google/yapf#why-does-yapf-destroy-my-awesome-formatting