Skip to content

[pre-commit] make pre-commit a single pipeline #43469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2022
Merged

[pre-commit] make pre-commit a single pipeline #43469

merged 5 commits into from
Jun 14, 2022

Conversation

betterpig
Copy link
Contributor

@betterpig betterpig commented Jun 13, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

make pre-commit a single pipeline to make code style check result more clearly.

@betterpig betterpig closed this Jun 14, 2022
@betterpig betterpig reopened this Jun 14, 2022
@betterpig betterpig closed this Jun 14, 2022
@betterpig betterpig reopened this Jun 14, 2022
luotao1
luotao1 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，可以合并后开启pre_commit流水线的required机制，然后删除static-check流水线中的老脚本

@luotao1 luotao1 merged commit cb2958a into PaddlePaddle:develop Jun 14, 2022
sneaxiy pushed a commit to sneaxiy/Paddle that referenced this pull request Jun 27, 2022
@betterpig @sneaxiy
[pre-commit] make pre-commit a single pipeline (PaddlePaddle#43469)
dbb8ec7
@SigureMo SigureMo mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betterpig @luotao1