【code format check upgrade】 step2：yapf #42944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
added 2 commits
June 3, 2022 03:46
…file, and format will break them
|
paddle_build.sh是因为修改的文件太多，所以先做修改，等PR merge后再revert么？ |
|
static-check也卡住了，paddle_build.sh对git diff的修改，不仅要修改coverage流水线相关的，还需要修改static-check流水线相关的。也可以先豁免等这个PR merge后，revert paddle_build.sh的修改 |
我觉得可以先merge了，yapf的合入不会对static_check造成影响。等合入后，我再提个PR改回来。就是改了检查python文件覆盖率的功能，先合入再马上改回来，影响很小。 |
This was referenced Jun 5, 2022
fuyou765
pushed a commit
to fuyou765/Paddle
that referenced
this pull request
Jun 7, 2022
* use yapf to format all python file * yapf exclude two unittests file for they rely on writing and reading file, and format will break them * disable diff_py_file because too many diff files cause command following failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
use yapf of 0.32.0 to format all python file.
some points:
- temporarily dissable using git to find out diff python files in check_diff_file_for_coverage, for the diff_py_files is too many that cause the shell script cant execute successfully.