[New API] add API paddle.vision.transforms.RandomErasing and paddle.vision.transforms.erase #42280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
c58420a to
dcfe74b
Compare
qingqing01
reviewed
Apr 28, 2022
| @@ -1297,6 +1298,144 @@ def _apply_image(self, img): | |||
| self.center, self.fill) | |||
|
|
|||
|
|
|||
| class RandomErasing(BaseTransform): | |||
| """Erase the pixels in a rectangle region selected randomly. This transform only | |||
| supports Tensor. | |||
There was a problem hiding this comment.
Remove "This transform only supports Tensor"
There was a problem hiding this comment.
Done，同时修改了class中其他文档的错误。
| pil_img = Image.fromarray(np_img).convert('RGB') | ||
|
|
||
| F.erase(np_img, 10, 10, 5, 5, 0, inplace=True) | ||
| np.testing.assert_equal(np_img[12, 12, 0], 0) |
| np.testing.assert_equal(np_img[12, 12, 0], 0) | ||
|
|
||
| pil_result = F.erase(pil_img, 10, 10, 5, 5, 0) | ||
| np.testing.assert_equal(np.array(pil_result)[12, 12, 0], 0) |
There was a problem hiding this comment.
Done, 新增了Tensor类型输入的测试用例
zhiboniu
reviewed
Apr 28, 2022
| else: | ||
| value = self.value | ||
| if value is not None and not (len(value) == 1 or | ||
| len(value) == img.shape[-3]): |
There was a problem hiding this comment.
这里img.shape[-3]是不是只是[c,h,w]的场景
| tensor_img = paddle.randn((3, 28, 28), dtype='float32') | ||
|
|
||
| F.erase(np_img, 10, 10, 5, 5, 0, inplace=True) | ||
| np.testing.assert_equal(np_img[10:15, 10:15, :], 0) |
b277046 to
bf0f8db
Compare
qingqing01
previously approved these changes
Apr 28, 2022
25d2691 to
c5add50
Compare
a7cdd5c to
596f7c1
Compare
qingqing01
approved these changes
May 5, 2022
dingjiaweiww
approved these changes
May 5, 2022
| img_area = h * w | ||
| log_ratio = np.log(ratio) | ||
| for _ in range(10): | ||
| erase_area = np.random.uniform(*scale) * img_area |
There was a problem hiding this comment.
这里不使用paddle原生api，而大量使用numpy的原因是什么？
There was a problem hiding this comment.
这个函数的作用在于确定erase函数执行时的参数数值，用numpy或者python原生数值处理主要有以下几个原因：
- 这里只需要数值/标量的结果即可，且不需要反向梯度。
- erase函数本身同时包含了numpy / paddle两种backends的实现。paddle api是针对Tensor进行处理，在numpy backends的函数中，需要额外引入一些Tensor和numpy/scalar的转化步骤。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add new API
paddle.vision.transforms.RandomErasingandpaddle.vision.transforms.erase. These two APIs are used to erase pixels from a random selected area in given image.The DOC pr is : #4071