Skip to content

fix paddle.optimizer.SGD en docs #40479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix paddle.optimizer.SGD en docs #40479

merged 2 commits into from
Mar 16, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Mar 12, 2022 •
edited
Loading

PR types

Others

PR changes

Docs

Describe

related to PaddlePaddle/docs#4245

cn docs pr: PaddlePaddle/docs#4304

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo
Copy link
Member Author

直接对齐中文文档，但这样在示例中删除了参数 weight_decay=0.01，如果加上这个参数更好的话（个人认为加上比较好？），我修改一下，然后在中文文档里新建 PR 添加上这个参数。

@SigureMo SigureMo changed the title align to cn docs fix paddle.optimizer.SGD en docs Mar 12, 2022
@SigureMo SigureMo mentioned this pull request Mar 12, 2022
Closed
TCChenlong
TCChenlong previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TCChenlong
Copy link
Contributor

是的，加上 weight_decay 会更好

@TCChenlong TCChenlong added the contributor External developers label Mar 15, 2022
@SigureMo SigureMo mentioned this pull request Mar 15, 2022
Merged
@SigureMo
Copy link
Member Author

@TCChenlong 已经改好啦～中文文档 PR 见 PaddlePaddle/docs#4304

@TCChenlong TCChenlong merged commit 8e63171 into PaddlePaddle:develop Mar 16, 2022
@SigureMo SigureMo deleted the fix-sgd-en-docs branch March 16, 2022 09:48
liqitong-a pushed a commit to liqitong-a/Paddle that referenced this pull request Mar 17, 2022
@SigureMo @liqitong-a
fix paddle.optimizer.SGD en docs (PaddlePaddle#40479)
6e37b0f 
* align to cn docs

* add parameter `weight_decay`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SigureMo @TCChenlong