Skip to content

[ARM] fix global_avg_pool and rnn fp16 overflow #9770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2022
Merged

[ARM] fix global_avg_pool and rnn fp16 overflow #9770

merged 1 commit into from
Nov 30, 2022

Conversation

mjp9527
Copy link
Collaborator

@mjp9527 mjp9527 commented Nov 28, 2022 •
edited
Loading

PR Type

bug fix

PR change

Arm CPU backends && test

Describe

rnn fp16 kernel计算会溢出，先去掉；global avg pooling fp16累加时会溢出，改为先除以数据量再累加；

@paddle-bot
Copy link

paddle-bot bot commented Nov 28, 2022

Thanks for your contribution!

@mjp9527 mjp9527 changed the title [ARM] fix global_avg_pool and rnn fp16 overflow (#9763) [ARM] fix global_avg_pool and rnn fp16 overflow Nov 28, 2022
liyancas
liyancas approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@liyancas liyancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjp9527 mjp9527 merged commit b28536d into PaddlePaddle:release/v2.12 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhupengyang zhupengyang Awaiting requested review from zhupengyang zhupengyang is a code owner

@hong19860320 hong19860320 Awaiting requested review from hong19860320 hong19860320 is a code owner

1 more reviewer

@liyancas liyancas liyancas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjp9527 @liyancas