[release/v2.12][HuaweiAscendNPU] Enhance dynamic range feature (#9504) #9615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhupengyang
approved these changes
Nov 1, 2022
Comment on lines
+26
to
+28
| std::vector<int32_t> GetShape(core::Operand* input_operand, | ||
| core::Operand* output_operand, | ||
| uint32_t shape_count) { |
There was a problem hiding this comment.
为什么需要重新推导，直接从 output_operand 中取就可以吧？已经在 PrepareReshape 中推导过了啊
There was a problem hiding this comment.
之前是PrepareReshape没有对Dynamic Shape的场景做处理，Ascend内部就单独做推导了，不过现在看来好像可以把这段逻辑迁移过去。
后面我看下吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.