Skip to content

Conversation

theckman
Copy link
Collaborator

In between raising #332 and merging it, there were changes to the master branch
that resulted in the tests in this PR breaking after the merge.

In hindsight, this branch should have been rebased against master before merging
the PR.

In between raising #332 and merging it, there were changes to the master branch
that resulted in the tests in this PR breaking after the merge.

In hindsight, this branch should have been rebased against master before merging
the PR.
@theckman theckman added this to the v1.5.0 milestone Oct 12, 2021
@theckman theckman requested a review from stmcallister October 12, 2021 05:55
@theckman
Copy link
Collaborator Author

@stmcallister I could use your 👀 on this PR so I can merge it as a fast-follow.

Copy link

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@theckman theckman merged commit 7a1cc59 into master Oct 12, 2021
@theckman theckman deleted the hotfix_after_merge branch October 12, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants