Skip to content

Add omitempty on Service.SupportHours and Service.ScheduledActions #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

Add omitempty on Service.SupportHours and Service.ScheduledActions #352

merged 1 commit into from
Aug 30, 2021

Conversation

theckman
Copy link
Collaborator

The lack of omitempty on these fields is causing CreateService calls to fail
when both are omitted. This broke in the v1.4.0 release so this is a bug fix.

Relates to #348

Fixes #346

@theckman
Add omitempty on Service.SupportHours and Service.ScheduledActions
667895e 
The lack of `omitempty` on these fields is causing `CreateService` calls to fail
when both are omitted. This broke in the v1.4.0 release so this is a bug fix.

Relates to #348

Fixes #346
@theckman theckman added this to the v1.4.2 milestone Aug 30, 2021
@theckman theckman merged commit 77565cd into release-1.4.x Aug 30, 2021
@theckman theckman deleted the fix_CreateService branch August 31, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@theckman