Skip to content

Update incident.go to accept a context.Context #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

Update incident.go to accept a context.Context #309

merged 1 commit into from
Mar 17, 2021

Conversation

theckman
Copy link
Collaborator

@theckman theckman commented Mar 6, 2021

Updates #267

@theckman theckman added this to the v1.4.0 milestone Mar 6, 2021
@theckman theckman requested a review from stmcallister March 6, 2021 02:41
@theckman theckman mentioned this pull request Mar 6, 2021
Closed
22 tasks
stmcallister
stmcallister approved these changes Mar 17, 2021
View reviewed changes
Copy link

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks inline with other ctx changes. 👍

@stmcallister stmcallister merged commit 1428ccf into master Mar 17, 2021
@stmcallister stmcallister deleted the ctx_incident branch March 17, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@stmcallister stmcallister stmcallister approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@theckman @stmcallister