Update internal HTTP methods to not take pointer to map as argument #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map types themselves are reference types, and can be passed in as `nil` even without declaring the value as a pointer to the map. Likewise, for maps that are nil the `range` operator is safe and no-ops and so we do not need a nil check before doing the range. If for some reason we wanted a check, a length check would be more appropriate than a nil check but it's not necessary.
|
@stmcallister this is a no-op, so it may make sense to also get it merged before 1.4.0. |
stmcallister
approved these changes
Feb 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map types themselves are reference types, and can be passed in as
nilevenwithout declaring the value as a pointer to the map.
Likewise, for maps that are nil the
rangeoperator is safe and no-ops and sowe do not need a nil check before doing the range. If for some reason we wanted
a check, a length check would be more appropriate than a nil check but it's not
necessary.