Skip to content

Event v2 client #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2020
Merged

Event v2 client #241

merged 5 commits into from
Oct 16, 2020
+84 −20

Conversation

goatherder
Copy link
Contributor

Implements ManageEvent for the pagerduty Client - so we can mock it out and test it.

@goatherder goatherder mentioned this pull request Sep 14, 2020
Closed
@goatherder goatherder mentioned this pull request Oct 6, 2020
Closed
@Sjeanpierre Sjeanpierre mentioned this pull request Oct 9, 2020
Merged
stmcallister
stmcallister approved these changes Oct 16, 2020
View reviewed changes
Copy link

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for contributing these changes!

@stmcallister stmcallister merged commit 32373a5 into PagerDuty:master Oct 16, 2020
Sjeanpierre added a commit that referenced this pull request Oct 19, 2020
@Sjeanpierre
Refactored to match PR #241 style
ee63a20
@theckman theckman added this to the v1.4.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@stmcallister stmcallister stmcallister approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@goatherder @stmcallister @theckman