[CSGI-2365] Add client User Agent overwrite capability #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckCrawford
requested changes
Dec 13, 2023
04b1787 to
e779842
Compare
ChuckCrawford
approved these changes
Dec 15, 2023
e779842 to
4e75a14
Compare
ChuckCrawford
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases introduced...
$ go test -count=1 -v -run TestClient_UserAgent === RUN TestClient_UserAgentDefault --- PASS: TestClient_UserAgentDefault (0.00s) === RUN TestClient_UserAgentOverwrite --- PASS: TestClient_UserAgentOverwrite (0.00s) PASS ok github.com/PagerDuty/go-pagerduty 0.667s