Skip to content

Conversation

imjaroiswebdev
Copy link
Contributor

This update addresses ListResponsePlays method lacking of the capability for setting the From header value required for making valid API calls to the corresponding endpoint, as a result, each call to this method would be returning the following error...

"HTTP response with status code 400 does not contain Content-Type: application/json"

Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to proceed with this change let's tighten up the Client.get function signature. See the in-line comment for more detail.

@imjaroiswebdev imjaroiswebdev force-pushed the response-plays-no-from-header branch from d681551 to 361d18f Compare November 2, 2023 18:28
@ChuckCrawford ChuckCrawford merged commit bcffd24 into PagerDuty:main Nov 2, 2023
gringus pushed a commit to gringus/go-pagerduty that referenced this pull request Jan 26, 2024
…agerDuty#502)

* Adds `From` header to `ListResponsePlays` method options
* Updates `Client.get` signature to accept headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants