Skip to content

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Oct 12, 2023

Add support for Standards APIs...

Test cases added...

$ go test -count=1 -v -run TestStandard
=== RUN   TestStandard_List
--- PASS: TestStandard_List (0.00s)
=== RUN   TestStandard_Update
--- PASS: TestStandard_Update (0.00s)
=== RUN   TestStandard_ListTechniServiceStandardScores
--- PASS: TestStandard_ListTechniServiceStandardScores (0.00s)
=== RUN   TestStandard_ListManyTechniServiceStandardScores
--- PASS: TestStandard_ListManyTechniServiceStandardScores (0.00s)
PASS
ok      github.com/PagerDuty/go-pagerduty       0.709s

@imjaroiswebdev imjaroiswebdev force-pushed the service-standards-support branch from 83317c8 to eb6becc Compare October 17, 2023 15:50
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review October 17, 2023 16:02
@imjaroiswebdev imjaroiswebdev changed the title [CSGI-1764 ] Add Standards support [CSGI-1827] Add Standards support Oct 17, 2023
Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes needed but otherwise this looks okay.

For future reference: it is not required to add CLI support when a new API is added to this library.

@ChuckCrawford ChuckCrawford merged commit 5b245db into PagerDuty:main Oct 24, 2023
gringus pushed a commit to gringus/go-pagerduty that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants