Skip to content

Added support for auto_pause_notifications_parameters #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

darrendao
Copy link
Contributor

@darrendao darrendao commented Jul 24, 2023

Updated Service struct to support auto_pause_notifications_parameters as per https://developer.pagerduty.com/api-reference/165ad96a22ffd-get-a-service.
I'm guessing this is a newer feature that got released but never made its way into this go lib code.

@darrendao
Copy link
Contributor Author

@ChuckCrawford is this something you can help review/approve/merge?

@darrendao
Copy link
Contributor Author

@jolexa @joelcrocker @helderberto @gempesaw @gsreynolds @cmrberry Is this something any of you can help get moving?

@ChuckCrawford ChuckCrawford self-requested a review August 4, 2023 16:49
@ChuckCrawford ChuckCrawford self-assigned this Aug 4, 2023
Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is a newer feature that got released but never made its way into this go lib code.

You are correct @darrendao . Thank you for contributing this and for following up with us!

@ChuckCrawford ChuckCrawford merged commit 043968a into PagerDuty:main Aug 4, 2023
gringus pushed a commit to gringus/go-pagerduty that referenced this pull request Jan 26, 2024
* Updated Service struct to support auto pause feature
* Added unit test for AutoPauseNotificationsParameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants