Refactor nil *string initialization #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes good sense. Thank you for the contribution @typeid. |
ChuckCrawford
approved these changes
Sep 22, 2023
gringus
pushed a commit
to gringus/go-pagerduty
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR?
strPtrhelper function, as it is not necessary and was missleading.Why?
strPtrfunction was used to initialize a string and get its pointer in a single line. As this was only used for initializing empty strings and returning their pointer, it's equivalent tonew(string). For unit tests, it makes sense to reference the same values for the created json and the unmarshalled output.strPtrfunction was missleading because it took a string by copy instead of reference, meaning that it would not return the pointer to the passed string, but to the copy.