Skip to content

Add resolved_at and updated_at fields to Incident #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add resolved_at and updated_at fields to Incident #482

merged 1 commit into from
Jul 11, 2023

Conversation

surik
Copy link
Contributor

@surik surik commented May 9, 2023

@dnwe
Copy link

dnwe commented Jun 23, 2023

Commit and PR title should be Add resolved_at and updated_at fields to Incident as created_at already exists. Otherwise change is correct and working well via a replace { .. } directive. Would be good to get this fix into the next version release

@dnwe dnwe mentioned this pull request Jun 23, 2023
Closed
@surik surik force-pushed the add-incident-resolved-and-updated-at branch from a4075f6 to 9610cda Compare June 23, 2023 15:18
@surik surik changed the title Add resolved_at and created_at fields to Incident Add resolved_at and updated_at fields to Incident Jun 23, 2023
@surik
Copy link
Contributor Author

surik commented Jun 23, 2023

@dnwe thank you for pointing out. This is fixed.

@ChuckCrawford ChuckCrawford self-requested a review July 11, 2023 12:30
ChuckCrawford
ChuckCrawford approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for doing this!

@ChuckCrawford ChuckCrawford merged commit 2d652e0 into PagerDuty:main Jul 11, 2023
gringus pushed a commit to gringus/go-pagerduty that referenced this pull request Jan 26, 2024
@surik @gringus
Add resolved_at and updated_at fields to Incident (PagerDuty#482)
40c4a3e 
As per documentation: https://developer.pagerduty.com/api-reference/9d0b4b12e36f9-list-incidents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckCrawford ChuckCrawford ChuckCrawford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surik @dnwe @ChuckCrawford