Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PagerDuty/go-pagerduty
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.2
Choose a base ref
...
head repository: PagerDuty/go-pagerduty
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.3
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 14, 2021

  1. Backport PR #382 to release-1.4.x branch 

    The bug this fixes was introduced as part of v1.4.0, so we need to backport it
into the v1.4.x release line. Because the master branch has diverged towards
v1.5.0, we need to manually backport this to the release-1.4.x branch.

Original commit message (0933613):

The PagerDuty REST API documentation[1] indicates that the errors field of an
error response is an array of error strings. However, as shown in #339 the API
sometimes violates that specification and instead returns the errors field as
a string.

There is a PagerDuty customer support ticket open[2] to to address this issue, but
there is currently no ETA on the resolution. As such we are going to create this
workaround to properly parse the invalid responses and return the proper error
type to callers.

Closes #339
Backports #382

[1] https://developer.pagerduty.com/docs/ZG9jOjExMDI5NTYz-errors
[2] https://tickets.pagerduty.com/hc/requests/341221
    @theckman
    theckman committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    8d10ae4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #386 from PagerDuty/backport_382_to_1.4.x 

    Backport PR #382 to release-1.4.x branch
    @theckman
    theckman committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    9f7230f View commit details
    Browse the repository at this point in the history

  3. Prep v1.4.3 release notes and bump Version const

    @theckman
    theckman committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    1b50dde View commit details
    Browse the repository at this point in the history

  4. Merge pull request #387 from PagerDuty/release-1.4.3 

    Prep v1.4.3 release notes and bump Version const
    @theckman
    theckman committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    6ab2995 View commit details
    Browse the repository at this point in the history
Loading