Feat: Version strings can now be modified and merged into a complex multiline files. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @zshel ! This looks good, but I'd like to see a passing test included in the PR as well. |
I don't think the failures have to do with anything I changed, but I'll take a deeper dive. |
|
yeah don't worry about the failures in the existing tests. Just write a new test for your feature |
…he old chef image
…use of the old chef image" Due to the deprecation of v3 This reverts commit bcbcc7f.
|
Added a test to cover the new merge option, also added some more tests to cover the general engine as well. Fixed the CI tests as well, although the chef is still broken, it appears because it's base docker image is so old. |
|
Thanks @AnalogJ! |
This was referenced Apr 25, 2025
|
hahaha I love this plan. BumprCon NYC? Or should we book a conference center in LA? I'm also open to visiting the BumprCon EU chapter. |
This was referenced Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of matching the whole file with the template, you can now only match a single line and merge the new version into the previous file without overwriting the entire version file.