Add double-bracket strings #752

max-sixty · 2022-07-02T04:24:08Z

No description provided.

max-sixty · 2022-07-02T04:26:07Z

Would close #721. I need to add to the docs.

I had previously implemented an rs"foo" string. But actually I think the double-bracket approach is fairly standard, and more closely aligns with the current problem. Definitely open to feedback though.

prql-compiler/src/prql.pest

max-sixty · 2022-07-03T20:24:45Z

Currently the SQL formatter is changing {?foo} to ( ? foo }. I need to think about the best way of dealing with this — is there some generalized way (i.e. all valid across dialects) of surrounding the expression so that the SQL formatter doesn't mangle it, but it's still valid?

Otherwise we'll have to replace it with something and then swap it back after the formatting, which would be a bit inelegant.

max-sixty · 2022-07-07T16:27:43Z

Possibly the way to do this is to surround double-bracket strings with dialect-specific "quotes" — e.g. for MySQL & BigQuery, we use backticks; for others we use double-quotes.

I can't see an escape hatch like we do for jinja expressions (https://github.com/prql/prql/blob/0.2.0/prql-compiler/src/sql/translator.rs#L46).

mklopets · 2022-07-08T13:59:06Z

Currently the SQL formatter is changing {?foo} to ( ? foo }

fyi, just as a related data point, our PRQL pipeline already does this kind of replacing post-compilation as we use postgres's @? inside of an S-string, which gets mangled to @ ? (i.e. invalid sql)

max-sixty · 2022-07-11T04:01:10Z

Thanks for that case @mklopets

I increasingly think we should parse to some representation of "raw ident", e.g. backticks, and then based on the dialect convert to either backticks or double-quotes.

max-sixty · 2022-07-18T15:13:26Z

I increasingly think we should parse to some representation of "raw ident", e.g. backticks, and then based on the dialect convert to either backticks or double-quotes.

I'm planning to pursue this, combined with the approach in #809.

So:

from foo
select `{{bar}}`

becomes, for dialects that use double-quotes to surround "raw identifiers":

select "{bar}" from foo

or for those that use backticks:

select `{bar}` from foo

The only change here would be to compile {{bar}} into {bar} — i.e. double brackets become single brackets with no evaluation of the contained expression. Currently is an error since it attempts to evaluate {bar} as a PRQL expression.

Edit: for any future travelers, I didn't end up pursuing this exact approach — the s-string approach seems to cover the cases, with fewer additional language features.

* Remove unnecessary steps from GHAs

As dscribed in the comment, not worth the extra time to pin the version

* Add section to contributing explaining our tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* rename java test package name * cross try * release conf * fix tests * update doc * profile adjustment * pre-commit * update developers Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> Co-authored-by: Maximilian Roos <m@maxroos.com>

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 1 to 3. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v1...v3) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@baptiste0928

* Improve GHA caching Swap out actions-rs for @baptiste0928 crate * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Now we no longer have the playground, no need to use wasm to test the book

…#816)

Removing this because it generates a 404, as per #818. Is there a way to link to a section on the homepage? Linking to prql-lang.org/index.html#Bindings doesn't seem to work either.

…#817) Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 14.2.3 to 14.2.5. - [Release notes](https://github.com/testing-library/user-event/releases) - [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md) - [Commits](testing-library/user-event@v14.2.3...v14.2.5) --- updated-dependencies: - dependency-name: "@testing-library/user-event" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: link to list of bindings from faq * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * avoid setting empty id for most sections * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix python releaes workflow Really we should have a test release workflow running which does a dry-run, so we don't get these sorts of problems (which I'm sure was my fault tbc...)

* Adding row_number_id to ROW_NUMBER() SQL to make them unique * Adding tests for #826 * Fixing clippy * Testing raw flag to pass the deadlinks check * Apply suggestions from code review Try reverting raw link change Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>

* Only run check-links on modified files And then run every day on all. This should reduce the issues we had in #853, not the first time we've had them. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Only install wasm-pack in CI when needed GHA builds are getting longer now, we're well past our 1 minute target... Though this isn't going to help much!

* Add some workflows to track our compilation time It's getting quite long now — CI jobs take 90-150 seconds, almost all of which is compilation, even with a cache. Locally I'm seeing more like 20s after wiping `target`. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * . * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Busts cache so #860 will cache correctly

* Remove cached cargo-timings files in GHA

Another cache bust, this time for #864

Weirdly the book printed an error, but passed?! https://github.com/prql/prql/runs/7530558870?check_suite_focus=true (this was from #1513, zero stress tbc)

* Fix BigQuery quoting Not sure this will be the end of it, but progress * .

Bumps [insta](https://github.com/mitsuhiko/insta) from 1.16.0 to 1.17.0. - [Release notes](https://github.com/mitsuhiko/insta/releases) - [Changelog](https://github.com/mitsuhiko/insta/blob/master/CHANGELOG.md) - [Commits](https://github.com/mitsuhiko/insta/commits) --- updated-dependencies: - dependency-name: insta dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Guessing this was an oversight

* Switch implicit `compile` tests to actual `compile` tests

Bumps [wasm-react-scripts](https://github.com/Cosmian/create-react-app/tree/HEAD/packages/react-scripts) from 5.0.2 to 5.0.3. - [Release notes](https://github.com/Cosmian/create-react-app/releases) - [Changelog](https://github.com/Cosmian/create-react-app/blob/main/CHANGELOG-1.x.md) - [Commits](https://github.com/Cosmian/create-react-app/commits/react-error-overlay@5.0.3/packages/react-scripts) --- updated-dependencies: - dependency-name: wasm-react-scripts dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

max-sixty · 2022-07-29T20:29:22Z

Not sure what's going on with the commit history but it'll be squashed...

Added some docs too; lmk if anything is unclear!

Add double-bracket strings

2e25d6c

max-sixty added 3 commits July 1, 2022 21:56

38c0ffc

250e006

Merge branch 'main' into double-brackets

6adb0bf

max-sixty commented Jul 2, 2022

View reviewed changes

prql-compiler/src/prql.pest Outdated Show resolved Hide resolved

Update prql-compiler/src/prql.pest

11d0554

max-sixty mentioned this pull request Jul 3, 2022

Pipeline of functions from PRQL to SQL #759

Closed

Merge branch 'main' into double-brackets

b4d9ad4

aljazerzen mentioned this pull request Jul 12, 2022

Dialects for ident escaping #809

Merged

max-sixty mentioned this pull request Jul 18, 2022

Raw s-string #721

Closed

max-sixty and others added 14 commits July 29, 2022 11:11

Remove unnecessary steps from GHAs (#805)

027fad5

* Remove unnecessary steps from GHAs

Remove version from mdbook-admonish install (#808)

eeafebc

As dscribed in the comment, not worth the extra time to pin the version

Improve GHA caching (#811)

548d8d9

* Improve GHA caching Swap out actions-rs for @baptiste0928 crate * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Use default target for book build (#813)

8ff848a

Now we no longer have the playground, no need to use wasm to test the book

Dialects for ident escaping (#809)

1b2e53e

prql-macros (#814)

3c7c8f3

Bump rusqlite from 0.27.0 to 0.28.0 (#815)

86f4490

Bump @testing-library/user-event from 14.2.1 to 14.2.3 in /playground (…

6e35f0b

…#816)

Remove incorrect link (#821)

4ca9c5e

Removing this because it generates a 404, as per #818. Is there a way to link to a section on the homepage? Linking to prql-lang.org/index.html#Bindings doesn't seem to work either.

max-sixty and others added 22 commits July 29, 2022 11:11

Fix python release workflow (#849)

a32893d

* Fix python releaes workflow Really we should have a test release workflow running which does a dry-run, so we don't get these sorts of problems (which I'm sure was my fault tbc...)

Only install wasm-pack in CI when needed (#855)

76e8d34

* Only install wasm-pack in CI when needed GHA builds are getting longer now, we're well past our 1 minute target... Though this isn't going to help much!

Update docs in ast_fold.rs (#857)

73fadb4

Precedence for unary operators and IS NULL (#859)

82dc7af

Test compilation time for all targets (#860)

1cd5b6f

Upgrade dependencies (#861)

aea4847

Busts cache so #860 will cache correctly

cli revamp (#863)

3388890

Reorganize top-level functions (#865)

6ad7a8f

Remove cached cargo-timings files in GHA (#864)

0566056

* Remove cached cargo-timings files in GHA

Bump deps (#867)

de142ca

Another cache bust, this time for #864

Fix links to stdlib.prql (#868)

37d09f0

Weirdly the book printed an error, but passed?! https://github.com/prql/prql/runs/7530558870?check_suite_focus=true (this was from #1513, zero stress tbc)

Fix BigQuery quoting (#858)

aa35ba7

* Fix BigQuery quoting Not sure this will be the end of it, but progress * .

Remove miscrate eprintln statement (#871)

1460716

Guessing this was an oversight

Final fix of BQ quotes (hopefully) (#874)

8e424e3

Switch implicit compile tests to actual compile tests (#875)

8e0d99a

* Switch implicit `compile` tests to actual `compile` tests

(cargo-release) version 0.2.4 (#877)

baff899

Only one workflow event per release (#878)

94c371a

max-sixty mentioned this pull request Jul 29, 2022

S-strings with literal curly braces #885

Closed

max-sixty added 2 commits July 29, 2022 13:17

Merge branch 'main' into double-brackets

cfd2b2c

.

d8ecf27

fba7571

max-sixty enabled auto-merge (squash) July 29, 2022 20:29

max-sixty merged commit e3aa960 into main Jul 29, 2022

max-sixty deleted the double-brackets branch July 29, 2022 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add double-bracket strings #752

Add double-bracket strings #752

Uh oh!

max-sixty commented Jul 2, 2022

Uh oh!

max-sixty commented Jul 2, 2022 •

edited

Loading

Uh oh!

Uh oh!

max-sixty commented Jul 3, 2022 •

edited

Loading

Uh oh!

max-sixty commented Jul 7, 2022

Uh oh!

mklopets commented Jul 8, 2022

Uh oh!

max-sixty commented Jul 11, 2022

Uh oh!

max-sixty commented Jul 18, 2022 •

edited

Loading

Uh oh!

max-sixty commented Jul 29, 2022

Uh oh!

Uh oh!

Add double-bracket strings #752

Add double-bracket strings #752

Uh oh!

Conversation

max-sixty commented Jul 2, 2022

Uh oh!

max-sixty commented Jul 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

max-sixty commented Jul 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-sixty commented Jul 7, 2022

Uh oh!

mklopets commented Jul 8, 2022

Uh oh!

max-sixty commented Jul 11, 2022

Uh oh!

max-sixty commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-sixty commented Jul 29, 2022

Uh oh!

Uh oh!

max-sixty commented Jul 2, 2022 •

edited

Loading

max-sixty commented Jul 3, 2022 •

edited

Loading

max-sixty commented Jul 18, 2022 •

edited

Loading