UseStatements::getType(): bug fix for unfinished closures #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and add an extra variant of the same test.
Of the new tests, test case 4 and 5, would previously both return `"import"` as the use statement type determination. This is clearly wrong. Additionally, for test case 3, it can also still be reliably determined that this is a closure `use`, while it would previously return an empty string as indicator of "undetermined". So when there is a parse error, but it can still be reliably determined that the `use` keyword is used for a closure `use` statement, the `UseStatements::getType()` method will now return `"closure"`. Includes tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseStatements tests: move parse error test to own file
... and add an extra variant of the same test.
UseStatements::getType(): bug fix for unfinished closures
Of the new tests, test case 4 and 5, would previously both return
"import"as the use statement type determination. This is clearly wrong.Additionally, for test case 3, it can also still be reliably determined that this is a closure
use, while it would previously return an empty string as indicator of "undetermined".So when there is a parse error, but it can still be reliably determined that the
usekeyword is used for a closureusestatement, theUseStatements::getType()method will now return"closure".Includes tests.