PHP 8.4: updates for exit as function call #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.4, `exit` and `die` will become "special" function calls and when used as a constant, it will be transformed to a function call at compile time. See the RFC for full details. With this in mind, it is appropriate to add `T_EXIT` to the `functionCallTokens()` and by inheritance to the `parameterPassingTokens()`. Includes unit tests. Ref: https://wiki.php.net/rfc/exit-as-function
As the `Collections::parameterPassingTokens()` array now contains `T_EXIT`, `exit` and `die` will now also be analyzable via the methods in the `PassedParameters` class. This commit: * Updates the documentation and the exception message to reflect this. * Adds various tests with `exit` and `die`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 | Collections::functionCallTokens(): add T_EXIT
As of PHP 8.4,
exitanddiewill become "special" function calls and when used as a constant, it will be transformed to a function call at compile time. See the RFC for full details.With this in mind, it is appropriate to add
T_EXITto thefunctionCallTokens()and by inheritance to theparameterPassingTokens().Includes unit tests.
Ref: https://wiki.php.net/rfc/exit-as-function
PassedParameters: minor update for support of exit
As the
Collections::parameterPassingTokens()array now containsT_EXIT,exitanddiewill now also be analyzable via the methods in thePassedParametersclass.This commit:
exitanddie.