Context::inForeachCondition(): bug fix - improve handling of array declaration in foreach #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…claration in foreach PHP allows for not just having an (array/iterable object) variable in the "iterable" (before as) part, it also allows for those to be passed as an expression. While this is surely more rare, it does mean that it is _possible_ for an `as` keyword to exist in the expression. This commit makes the `Context::inForeachCondition()` method more robust by explicitly skipping over array declarations while searching for the `as` keyword belonging to the `foreach`. This fixes the bug. Includes tests.
d133b8c to
50cc0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP allows for not just having an (array/iterable object) variable in the "iterable" (before as) part, it also allows for those to be passed as an expression.
While this is surely more rare, it does mean that it is possible for an
askeyword to exist in the expression.This commit makes the
Context::inForeachCondition()method more robust by explicitly skipping over array declarations while searching for theaskeyword belonging to theforeach. This fixes the bug.Includes tests.