✨ New FilePath utility class
#593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a675d0d to
c61fa32
Compare
|
Rebased without changes. Setting to draft as this PR depends on #550, which has to be merged first. |
0b69380 to
da08c72
Compare
c61fa32 to
4f0f9a4
Compare
Base automatically changed from
testutils/new-configdouble-utility-class
to
develop
May 20, 2024 17:55
|
Rebased without changes after the merge of PR #550. |
da08c72 to
44629fe
Compare
... with some utility functions for handling file paths. The class initially contains the following utility methods: * `getName(File $phpcsFile): string` - Retrieve the normalized file name for the current file. * `isStdin(File $phpcsFile): bool` - Check whether the current file under scan comes from STDIN. * `normalizeAbsolutePath(string $path): string` - Normalize an absolute path to forward slashes and to include a trailing slash for directories. * `normalizeDirectorySeparators(string $path): string` - Normalize all directory separators to be a forward slash. * `trailingSlashIt(string $path): string` - Ensure that a directory path ends on a trailing slash. * `startsWith(string $haystack, string $needle): bool` - Check whether one file/directory path starts with another path. Includes unit tests.
|
Rebased without changes. Note: I've looked the sniff over to check if any of the new exceptions from PR #598 should be implemented and concluded that things should be fine as-is. In all methods, it is either handled gracefully already or a param will be passed to a PHP native function, which may throw a type error. I think that should be sufficient. |
44629fe to
f87bfb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with some utility functions for handling file paths.
The class initially contains the following utility methods:
getName(File $phpcsFile): string- Retrieve the normalized file name for the current file.isStdin(File $phpcsFile): bool- Check whether the current file under scan comes from STDIN.normalizeAbsolutePath(string $path): string- Normalize an absolute path to forward slashes and to include a trailing slash for directories.normalizeDirectorySeparators(string $path): string- Normalize all directory separators to be a forward slash.trailingSlashIt(string $path): string- Ensure that a directory path ends on a trailing slash.startsWith(string $haystack, string $needle): bool- Check whether one file/directory path starts with another path.Includes unit tests.