Skip to content

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented May 10, 2024

This abstracts the parsing of a file out from the setUpTestFile() method, without changing the functionality.

Having the parsing of a file as a separate method allows for tests to parse a secondary test case file for use in a test.

As the new method doesn't create any functional changes, it is already covered by existing tests.

@jrfnl jrfnl added this to the 1.1.0 milestone May 10, 2024
@jrfnl jrfnl force-pushed the testutils/new-configdouble-utility-class branch 4 times, most recently from a675d0d to c61fa32 Compare May 13, 2024 11:30
@jrfnl jrfnl force-pushed the testutils/new-parsefile-method branch from 70efda6 to bb307c1 Compare May 13, 2024 11:31
@jrfnl
Copy link
Member Author

jrfnl commented May 13, 2024

Rebased without changes. Setting to draft as this PR depends on #550, which has to be merged first.

@jrfnl jrfnl marked this pull request as draft May 13, 2024 11:32
@jrfnl jrfnl force-pushed the testutils/new-configdouble-utility-class branch from c61fa32 to 4f0f9a4 Compare May 20, 2024 14:05
Base automatically changed from testutils/new-configdouble-utility-class to develop May 20, 2024 17:55
This abstracts the parsing of a file out from the `setUpTestFile()` method, without changing the functionality.

Having the parsing of a file as a separate method allows for tests to parse a secondary test case file for use in a test.

As the new method doesn't create any functional changes, it is already covered by existing tests.
@jrfnl jrfnl force-pushed the testutils/new-parsefile-method branch from bb307c1 to 0efda76 Compare May 20, 2024 17:56
@jrfnl
Copy link
Member Author

jrfnl commented May 20, 2024

Rebased without changes. Marking as ready as #550 has been merged now. Merging once the build passes.

@jrfnl jrfnl marked this pull request as ready for review May 20, 2024 17:58
@jrfnl jrfnl merged commit 3eacaec into develop May 20, 2024
@jrfnl jrfnl deleted the testutils/new-parsefile-method branch May 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant