PHP 8.4 | BackCompat\Helper: fix implicitly nullable types deprecation notice #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n notice The `$phpcsFile` parameter is optional for the `getEncoding()` and the `ignoreAnnotations` method, but the type declaration cannot be made nullable as the minimum supported PHP version of this package is PHP 5.4, while PHP 7.1 is needed for the nullable operator. Removing the `File` type declaration effectively widens the type to `mixed`, which fixes the deprecation notice. As the class is `final`, this change does not constitute a BC-break. Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$phpcsFileparameter is optional for thegetEncoding()and theignoreAnnotations()method, but the type declaration cannot be made nullable as the minimum supported PHP version of this package is PHP 5.4, while PHP 7.1 is needed for the nullable operator.Removing the
Filetype declaration effectively widens the type tomixed, which fixes the deprecation notice.As the class is
final, this change does not constitute a BC-break.Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types