Return types properly with disjunctive normal form #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch would be completely invalidated by the proposed patch for PHPCSStandards/PHP_CodeSniffer#387. Also, the tests are not in the right place. For those very select situations where PHPCSUtils would be ahead of PHPCS for fixes to the "mirror"-methods, the tests for the "difference" should be handled in the |
0fa04d6 to
f6a6111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been down a rabbit hole today. I started with PHPCompatibility/PHPCompatibility#1689 and then found #566 and am now here to return the proper type information for disjunctive normal form parameters. I have included a reference to PHPCSStandards/PHP_CodeSniffer#387 as there is a bug in PHP_CodeSniffer itself where the union operator for a disjunctive normal form is sometimes tokenised as
T_BITWISE_OR. If you would prefer, I can remove that work-around from this pull request and wait until PHPCSStandards/PHP_CodeSniffer#387 is fixed instead.