AbstractArrayDeclarationSniff: improve the property reset #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsetting a property leaves a property in a different PHP internal state then (re)setting it to an empty value. Most notably, an unset property triggers the magic `__set()`/`__get()` etc methods if available, and while this abstract doesn't declare those methods, a sniff implementing the abstract _may_. This change maintains the target behaviour (resetting the property values to save memory), while preventing side-effects from using `unset()` on these properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsetting a property leaves a property in a different PHP internal state then (re)setting it to an empty value.
Most notably, an unset property triggers the magic
__set()/__get()etc methods if available, and while this abstract doesn't declare those methods, a sniff implementing the abstract may.This change maintains the target behaviour (resetting the property values to save memory), while preventing side-effects from using
unset()on these properties.