BCFile::getMethodParameters(): sync with upstream / readonly without visibility #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…visibility PHPCS upstream has now also added support for constructor property promotion with `readonly` properties without explicit visibility. This commit updates the `BCFile::getMethodParameters()` method to reflect this. Support for readonly constructor properties without visibility was previously already added to the `FunctionDeclarations::getParameter()` in PR 456. The associated "diff" test has now been moved to the base test file for these methods. Refs: * squizlabs/PHP_CodeSniffer 3801.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS upstream has now also added support for constructor property promotion with
readonlyproperties without explicit visibility.This commit updates the
BCFile::getMethodParameters()method to reflect this.Support for readonly constructor properties without visibility was previously already added to the
FunctionDeclarations::getParameter()method in PR #456.The associated "diff" test has now been moved to the base test file for these methods.
Refs: