Skip to content

Bugfixes for masterslide issues: issue #330, problems with broken powerpoints needing repair, missing images in shapes #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 15, 2017
Merged

Bugfixes for masterslide issues: issue #330, problems with broken powerpoints needing repair, missing images in shapes #372

merged 14 commits into from
Jun 15, 2017

Conversation

Fake51
Copy link
Contributor

@Fake51 Fake51 commented Jun 8, 2017 •
edited
Loading

Fixes bugs in saving master slides:

  • draw shapes are not included in data written, because only shapes from regular slides are iterated over
  • IDs used in relationship files linking powerpoint master slides to media are doubles - which leads to "broken" images when opening powerpoint files and PowerPoint 2010+ trying to repair the files
  • background images in masterslides are neither written nor linked

Peter Lind and others added 9 commits June 8, 2017 14:20
@Fake51 Fake51 closed this Jun 9, 2017
@Fake51 Fake51 reopened this Jun 9, 2017
@Fake51 Fake51 changed the title Bugfix for draw shapes in master slides Bugfixes for masterslide issues: issue #330, problems with broken powerpoints needing repair, missing images in shapes Jun 9, 2017
@Progi1984 Progi1984 self-assigned this Jun 15, 2017
@Progi1984 Progi1984 added this to the 0.9.0 milestone Jun 15, 2017
@Progi1984 Progi1984 merged commit 53bbaea into PHPOffice:develop Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Progi1984 Progi1984

Labels
Component - PowerPoint2007 Source - Pull Request
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Fake51 @Progi1984