-
Notifications
You must be signed in to change notification settings - Fork 533
Add appear animation to phppresentation for Powerpoint2007 writer #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JewrassicPark Before merging, you need to fix PHPCS & PHPMd errors : |
fixed style issues
fixed style issues
updated for style
ive updated the style in my fork |
removed whitespace on line 23
corrected for style
update for style
updated style errors on line 278
Added to writeNote function to add in xml to display slide preview above notes when printing slide
public function getAnimations() | ||
{ | ||
return $this->animations; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That lacks a setAnimations(array $animations = array())
@JewrassicPark Could you add a sample ? Which type of animation could you define ? |
It only does appear animation currently Here is a use example:
|
I'll work with #179 before this one :) |
@@ -180,7 +180,7 @@ public function writeSlide(SlideElement $pSlide = null) | |||
$objWriter->endElement(); | |||
|
|||
// Loop shapes | |||
$shapeId = 0; | |||
$shapeId = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JewrassicPark Why have you changed this ?
It seemed like powerpoint was treating shape 0 as the slide itself. IIRC I couldn't get the animations to work when the shape index started at 0. |
@JewrassicPark Animations or Slide notes ? |
I believe that was changed specifically for animations. I'm not sure if it affects the slide notes either way. |
@JewrassicPark Could you update your PR with the latest version of the develop branch ? |
I made a new pull request with a fork from the latest branch. I deleted my old fork, forked from the latest dev branch, added in my changes for animation and tested it. Is there a better way to do that? It was a pain in the ass and I'm not going to be doing it often. |
Added animation class, added animation tags to Powerpoint2007 Slide Writer, added animation objects to Slide.php
This only supports appear. Shapes can be grouped to appear together or sequentially by order they're added as animations.
Use: