Skip to content

PhpOffice\PhpPresentation\Style\TextStyle : Fixed typo for default indent #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Mar 6, 2025

Description

PhpOffice\PhpPresentation\Style\TextStyle : Fixed typo for default indent

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@Progi1984 Progi1984 added this to the 1.2.0 milestone Mar 6, 2025
@Progi1984 Progi1984 marked this pull request as ready for review March 6, 2025 12:17
@Progi1984 Progi1984 merged commit 2919ce7 into PHPOffice:master Mar 6, 2025
31 checks passed
@Progi1984 Progi1984 deleted the fixedTypo branch March 6, 2025 12:18
@coveralls
Copy link

Coverage Status

coverage: 91.639%. remained the same
when pulling 234b4f8 on Progi1984:fixedTypo
into 54b5b38 on PHPOffice:master.

@Brenneisen
Copy link
Contributor

Hi @Progi1984 can you already estimate when there will be a new release with these fixes?

@tuanpt-0634
Copy link

@Progi1984 @PowerKiKi @Brenneisen
This is an annoying bug. Can we release this PR in v1.1.1?

@PowerKiKi
Copy link
Member

@Progi1984 planned a release in May: #859 (comment)

@tuanpt-0634
Copy link

May is nearly over. I believe this is a bug that should be fixed in a patch release, since v1.2.0 might introduce new issues and we don't want to upgrade to 1.2.0 right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants